-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to run Outline on a server with another Watchtower #1255
base: master
Are you sure you want to change the base?
Conversation
57130f7
to
b0e7303
Compare
@@ -304,6 +304,7 @@ function start_shadowbox() { | |||
local -ar docker_shadowbox_flags=( | |||
--name "${CONTAINER_NAME}" --restart always --net host | |||
--label 'com.centurylinklabs.watchtower.enable=true' | |||
--label 'com.centurylinklabs.watchtower.scope=shadowbox' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this prevent watchtower itself from being updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the label and the flag will be applied simultaneously. So old version without the label and the flag will update itself to a new version with the label and the flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed scope name to make it a bit more explicit. PTAL
See https://containrrr.dev/watchtower/running-multiple-instances/ `com.centurylinklabs.watchtower.enable` and `--label-enable` are kept for backward compatibility. Closes Jigsaw-Code#48.
b0e7303
to
7720e77
Compare
@@ -333,10 +334,12 @@ function start_watchtower() { | |||
# testing). Otherwise refresh every hour. | |||
local -ir WATCHTOWER_REFRESH_SECONDS="${WATCHTOWER_REFRESH_SECONDS:-3600}" | |||
local -ar docker_watchtower_flags=(--name watchtower --restart always \ | |||
--label 'com.centurylinklabs.watchtower.enable=true' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
furthermore, this change now allows watchtower
to update itself
right now every instance of outline-server
has its watchtower
image stuck on the installation version due to the presence of --label-enable
Ping |
@fortuna poke |
See https://containrrr.dev/watchtower/running-multiple-instances/
com.centurylinklabs.watchtower.enable
and--label-enable
are kept for backward compatibility.Closes #48.